Re: [CORE] [BUGS] BUG #13350: blindly fsyncing data dir considered harmful

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Greg Stark <stark(at)mit(dot)edu>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, Stephen Frost <sfrost(at)snowman(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-core <pgsql-core(at)postgresql(dot)org>, Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [CORE] [BUGS] BUG #13350: blindly fsyncing data dir considered harmful
Date: 2015-05-25 15:52:33
Message-ID: 20150525155233.GD3908@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Mon, May 25, 2015 at 04:37:59PM +0100, Greg Stark wrote:
> What exactly is failing?
>
> Is it that fsync is returning -1 ? Should we just ignore errors from
> fsync if it happens in this stage? That might be safer than
> determining which files should or shouldn't be fsynced.

Interesting idea. We could skip fsync -1 failures only for symbolic
links.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Alvaro Herrera 2015-05-25 15:52:48 Re: Incorrect processing of CREATE TRANSFORM with DDL deparding
Previous Message Greg Stark 2015-05-25 15:37:59 Re: [CORE] [BUGS] BUG #13350: blindly fsyncing data dir considered harmful

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2015-05-25 15:55:42 Re: [CORE] [BUGS] BUG #13350: blindly fsyncing data dir considered harmful
Previous Message Greg Stark 2015-05-25 15:37:59 Re: [CORE] [BUGS] BUG #13350: blindly fsyncing data dir considered harmful