| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Andres Freund <andres(at)anarazel(dot)de>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Run pgindent now? |
| Date: | 2015-05-25 01:52:49 |
| Message-ID: | 20150525015249.GB3908@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, May 24, 2015 at 10:44:10AM -0400, Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> > On 05/23/2015 11:37 PM, Tom Lane wrote:
> >> No, pgindent has *always* been wonky about lines that contain a typedef
> >> name but are not variable declarations.
>
> > Well, that sounds like something we should try to patch, doesn't it?
> > (No, I'm not volunteering.)
>
> In the past, the main argument against changing pgindent has been that
> it would cause reformatting of settled code. For example, when Bruce
> twiddled its right margin limit for comments around 8.1, that caused
> literally years worth of back-patching pain. If we can get to an
> agreement on re-indenting back branches at the same time as master,
> then this problem would go away, and I for one would get a lot more
> enthusiastic about trying to improve pgindent rather than just working
> around its oddities.
>
> Not that I'm volunteering either right now.
That is something we will need to fix in the BSD indent code.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ Everyone has their own god. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2015-05-25 02:45:30 | Re: Free indexed_tlist memory explicitly within set_plan_refs() |
| Previous Message | Bruce Momjian | 2015-05-25 01:52:03 | Re: Run pgindent now? |