| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <bruce(at)momjian(dot)us>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Run pgindent now? |
| Date: | 2015-05-22 14:52:34 |
| Message-ID: | 20150522145234.GW5885@postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Robert Haas wrote:
> On Tue, May 19, 2015 at 10:26 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > To do it before every minor release would require re-indenting HEAD
> > as well (since the whole point is to keep HEAD and the back branches
> > consistent). I think we'd get too much push-back from developers
> > whose pending patches got broken. We can get away with reindenting
> > HEAD between development cycles, but probably not more often than that.
>
> I'm not convinced of that. If we did it more often, it might actually
> be less disruptive.
I believe it's possible to mechanically rebase a patch over an indent
run of the underlying branch with half a dozen commands or less. +1 for
reindenting all branches before each minor release, FWIW.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2015-05-22 15:09:32 | Re: Run pgindent now? |
| Previous Message | Tom Lane | 2015-05-22 14:50:53 | Re: Missing importing option of postgres_fdw |