| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, "D(dot) S(dot)" <spider(at)skuggor(dot)se>, pgsql-bugs(at)postgresql(dot)org |
| Subject: | Re: unrecognized option '--help |
| Date: | 2015-05-22 01:50:06 |
| Message-ID: | 20150522015006.GF2028@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On 2015-05-21 21:44:36 -0400, Tom Lane wrote:
> Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> > Michael Paquier wrote:
> >> It is wanted this way for all the utilities of src/bin. See
> >> handle_help_version_opts() in src/bin/scripts/common.c for your case.
>
> > Is it really wanted? I find it very annoying and wish it didn't do
> > that.
>
> I think the only thing that would do what you wanted would be to
> recognize *any* argv element matching "--help" as a help request.
> Maybe that's all right, but I'm a tad worried about the possibility
> of false positives. Are we so sure that that string could never be
> a database name, table name, etc?
I'm not following. Why does checking for --help/-? in the normal
getopt_long call require that? In many, but not all, utilities only
argv[1] is checked...
Andres
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2015-05-22 01:58:11 | Re: unrecognized option '--help |
| Previous Message | Tom Lane | 2015-05-22 01:44:36 | Re: unrecognized option '--help |