Re: Run pgindent now?

From: Noah Misch <noah(at)leadboat(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: Run pgindent now?
Date: 2015-05-16 16:49:05
Message-ID: 20150516164905.GA3782578@tornado.leadboat.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, May 16, 2015 at 11:58:59AM -0400, Tom Lane wrote:
> With feature freeze behind us, I'd like to propose that now is a good
> time for a pgindent run. It's possible we'd need another one before
> 9.5 is branched off from HEAD, but a run now ought to take care of 95%
> of the cleanup needed. I see a couple of advantages to doing it now:

+1 to Magnus's suggestion of doing it after the minor release wrap.

> The only significant downside I can think of is that, if we determine
> that any of the recent feature additions are so sketchy that they need
> to be reverted, having to undo just a portion of the pgindent commit
> before reverting the feature commit would be a pain. But I don't think
> we should optimize on the assumption that that will happen.

Quite so; we'd have lost our way to be optimizing for that.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2015-05-16 17:05:27 Re: Run pgindent now?
Previous Message Magnus Hagander 2015-05-16 16:30:55 Re: Run pgindent now?