Re: pgsql: Add pg_audit, an auditing extension

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Add pg_audit, an auditing extension
Date: 2015-05-14 19:21:35
Message-ID: 20150514192135.GK30322@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

* Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
> Stephen Frost <sfrost(at)snowman(dot)net> writes:
> > * Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
> >> Quite aside from any security risks, that means that running "make
> >> installcheck" twice in a row fails. Please fix.
>
> > Right, will do, though one kind of requires the other (we can't drop the
> > only user we know how to connect as which is a superuser...). I'll
> > figure out a way to make it work though.
>
> Instead of physically reconnecting, could you do SET ROLE or SET SESSION
> AUTHORIZATION? I think that's what we do in the core tests.

Alright, I believe this has been fixed now, using the brand-new \gset
option.

Two installcheck's in a row still breaks though.. I'm not quite sure
what to do about that but I'm certainly open to thoughts. I can reset
the role attributes later, but those get logged with the username used
too in the ALTER statement, which changes.

I'll continue to think about it though, perhaps there's a way I can
disable logging as the superuser without it logging the role involved.

Thanks!

Stephen

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Stephen Frost 2015-05-14 19:30:28 Re: pgsql: Add pg_audit, an auditing extension
Previous Message Stephen Frost 2015-05-14 19:16:31 pgsql: Improve pg_audit regression tests

Browse pgsql-hackers by date

  From Date Subject
Next Message Denis Kirjanov 2015-05-14 19:22:44 Re: trust authentication behavior
Previous Message Stephen Frost 2015-05-14 18:22:17 Re: [COMMITTERS] pgsql: Add pg_audit, an auditing extension