Re: pgsql: Add pg_audit, an auditing extension

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Add pg_audit, an auditing extension
Date: 2015-05-14 15:00:47
Message-ID: 20150514150047.GX30322@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

* Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
> Stephen Frost <sfrost(at)snowman(dot)net> writes:
> > And... I busted the buildfarm. Will fix.
>
> -- Load pg_audit module
> create extension pg_audit;
> + ERROR: pg_audit must be loaded via shared_preload_libraries
>
> This seems like a rather poorly thought-through error check.
> It will break not only the buildfarm but any dump/restore scenario.
> You really can't have extensions that refuse to let themselves
> be created.

Yeah, the original idea behind it was to force the user to think about
if they really would want to load it later on down the line rather than
have it pre-loaded always.

I'll put something in the docs which recommends it and provides the
reasoning behind it.

Thanks!

Stephen

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2015-05-14 15:06:10 Re: pgsql: Add pg_audit, an auditing extension
Previous Message Tom Lane 2015-05-14 14:59:01 Re: pgsql: Add pg_audit, an auditing extension

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2015-05-14 15:06:10 Re: pgsql: Add pg_audit, an auditing extension
Previous Message Tom Lane 2015-05-14 14:59:01 Re: pgsql: Add pg_audit, an auditing extension