Re: BUG #13179: pg_upgrade failure.

On Wed, May 6, 2015 at 02:58:01PM -0400, Corey Huinker wrote:
> Good to know about set search_path from current!
>
> However, this shows an issue: a database which appears functional to the
> customer will fail to upgrade, and the only error message in the log file
> complains of an object that does not exist, despite the same log file showing
> that it does. Customers, already frustrated, might find that error confusing,
> and might find the eventual explanation unsatisfying. After all, the database
> worked for them, and they never do the thing that will make their code break.
>
> The desired behavior would be an upgraded database that continues to have the
> problem of a function that will mal-function when a user changes their search
> path.
>
> Failing that, an improved error message would help.
>
> Alternately, a warning message at function creation time when
> ambiguously-pathed objects are referenced.

FYI, pg_upgrade is blindly calling pg_dump/pg_restore and erroring out
if there is any failure, so any fix would have to be done at that level.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +