From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
---|---|
To: | Emre Hasegeli <emre(at)hasegeli(dot)com> |
Cc: | Andreas Karlsson <andreas(at)proxel(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: BRIN range operator class |
Date: | 2015-05-05 18:49:00 |
Message-ID: | 20150505184900.GM2523@alvh.no-ip.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
After looking at 05 again, I don't like the "same as %" business.
Creating a whole new class of exceptions is not my thing, particularly
not in a regression test whose sole purpose is to look for exceptional
(a.k.a. "wrong") cases. I would much rather define the opclasses for
those two datatypes using the existing @> operators rather than create
&& operators for this purpose. We can add a note to the docs, "for
historical reasons the brin opclass for datatype box/point uses the <@
operator instead of &&", or something like that.
AFAICS this is just some pretty small changes to patches 05 and 06.
Will you please resubmit?
I just pushed patch 01, and I'm looking at 04 next.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Joshua D. Drake | 2015-05-05 19:06:45 | add -s to vacuumdb |
Previous Message | Tom Lane | 2015-05-05 18:01:41 | Re: Fixing busted citext function declarations |