| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Abhijit Menon-Sen <ams(at)2ndquadrant(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: initdb -S and tablespaces |
| Date: | 2015-04-30 22:18:08 |
| Message-ID: | 20150430221808.GW4369@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Robert Haas wrote:
> Also, it seems awfully unfortunate to me that we're duplicating a
> whole pile of code into xlog.c here. Maybe there's no way to avoid
> the code duplication, but pre_sync_fname() seems like it'd more
> naturally go in fd.c than here. I dunno where walkdir should go, but
> again, not in xlog.c.
Hm, there's an interest in backpatching this as a bugfix, if I
understand correctly; hence the duplicated code. We could remove the
duplicity later with a refactoring patch in master only.
However, now that you mention a pg_control flag, it becomes evident to
me that a change to pg_control cannot be back-patched ...
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2015-04-30 22:18:43 | Re: PATCH: adaptive ndistinct estimator v4 |
| Previous Message | Heikki Linnakangas | 2015-04-30 21:31:48 | Re: PATCH: adaptive ndistinct estimator v4 |