| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Timothy Garnett <tgarnett(at)panjiva(dot)com>, Postgres-Bugs <pgsql-bugs(at)postgresql(dot)org>, Kevin Grittner <kgrittn(at)ymail(dot)com> |
| Subject: | Re: Re: BUG #12990: Missing pg_multixact/members files (appears to have wrapped, then truncated) |
| Date: | 2015-04-28 17:54:14 |
| Message-ID: | 20150428175414.GC4369@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Alvaro Herrera wrote:
> > I think this is confusing:
> >
> > +/*
> > + * Read the offset of the first member of the given multixact.
> > + */
> >
> > This is confusing to me because the two subdirectories of pg_multixact
> > are called "members" and "offsets". Here you are talking about the
> > offset of the first member. Maybe I'm just slow, but that seems like
> > conflating terminology. You end up with a function called
> > read_offset_for_multi() that is actually looking up information about
> > members. Ick.
>
> Yeah, I introduced the confusing terminology while inventing multixacts
> initially and have regretted it many times. I will think about a better
> name for this. (Meanwhile, on IM Robert suggested
> find_start_of_first_multi_member)
Pushed. I chose find_multixact_start() as a name for this function.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | bzb.dev001 | 2015-04-28 18:10:07 | BUG #13188: .pgpass does not work |
| Previous Message | Robert Haas | 2015-04-28 16:04:47 | Re: Re: BUG #12990: Missing pg_multixact/members files (appears to have wrapped, then truncated) |