Re: BUG #13143: Cannot stop and restart a streaming server with a replication slot

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pdrolet(at)infodata(dot)ca, pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #13143: Cannot stop and restart a streaming server with a replication slot
Date: 2015-04-27 16:00:15
Message-ID: 20150427160015.GW4369@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Andres Freund wrote:
> On 2015-04-27 11:44:47 -0300, Alvaro Herrera wrote:
> > I think this is failing in the fsync_fname() call in slot.c line 1045
> > (REL9_4_STABLE).
>
> Patrice has since replied with log_error_verbosity=verbose logs, but
> that reply is probably still stuck in moderation:

Ah, sorry about that. Approved.

> Hm. I wonder if it's maybe that the file is opened with O_RDONLY? The
> OSs I have access to don't care - for good reason imo, fsync isn't a
> write - but it's not inconceivable that windows might.

Ah, fsync_fname() explicitely defends against this.

> So that's easy enough fixed.

Nice.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Marko Tiikkaja 2015-04-27 16:12:48 Re: BUG #13160: Incorrect escaping of quotes in JSON export
Previous Message Alvaro Herrera 2015-04-27 15:24:41 Re: BUG #12990: Missing pg_multixact/members files (appears to have wrapped, then truncated)