Re: pgsql: Fix incorrect matching of subexpressions in outer-join plan node

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Qingqing Zhou <zhouqq(dot)postgres(at)gmail(dot)com>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Fix incorrect matching of subexpressions in outer-join plan node
Date: 2015-04-24 21:12:27
Message-ID: 20150424211227.GA12723@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 2015-04-24 13:30:49 -0400, Tom Lane wrote:
> [ catching up on email post-vacation ]

Welcome back Tom! Hope you had a nice and relaxing time.

> It's okay to store resulttype and retset
> because we disallow changing the output type (including set-ness) of a
> function; but we don't want to disallow changing strictness for
> instance.

I don't think we forbid changing the volatility. I'm pretty sure I've
changed that using CREATE OR REPLACE in the past.

Yep:
postgres[l]=# CREATE FUNCTION blarg() RETURNS int VOLATILE LANGUAGE SQL AS $$SELECT 1;$$;
CREATE FUNCTION
postgres[l]=# CREATE OR REPLACE FUNCTION blarg() RETURNS int STABLE LANGUAGE SQL AS $$SELECT 1;$$;
CREATE FUNCTION

Greetings,

Andres Freund

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2015-04-24 21:13:12 pgsql: Fix up .gitignore and cleanup actions in some src/test/ subdirec
Previous Message Tom Lane 2015-04-24 19:18:57 pgsql: Fix obsolete comment in set_rel_size().