From: | Abhijit Menon-Sen <ams(at)2ndQuadrant(dot)com> |
---|---|
To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com> |
Subject: | Re: a fast bloat measurement tool (was Re: Measuring relation free space) |
Date: | 2015-04-24 02:34:10 |
Message-ID: | 20150424023410.GA9726@toroid.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
At 2015-04-24 07:22:27 +0530, amit(dot)kapila16(at)gmail(dot)com wrote:
>
> Few minor issues:
> 1.
> warning on windows
>
> \pgstatbloat.c(193): warning C4715: 'pgstatbloat' : not all control paths
> return a value
This is because the function ends with an ereport(ERROR, …). What would
you suggest here? Just stick a PG_RETURN_NULL() at the end?
> 2.
> Failed to install pgstattuple--1.3.sql
>
> You have to name sql file as pgstattuple--1.3.sql rather
> than pgstattuple--1.2.sql
How are you applying the patch? It already contains this:
diff --git a/contrib/pgstattuple/pgstattuple--1.2.sql b/contrib/pgstattuple/pgstattuple--1.3.sql
similarity index 73%
rename from contrib/pgstattuple/pgstattuple--1.2.sql
rename to contrib/pgstattuple/pgstattuple--1.3.sql
index e5fa2f5..93593ee 100644
--- a/contrib/pgstattuple/pgstattuple--1.2.sql
+++ b/contrib/pgstattuple/pgstattuple--1.3.sql
So it should do the right thing with git apply.
-- Abhijit
From | Date | Subject | |
---|---|---|---|
Next Message | Stephen Frost | 2015-04-24 03:04:59 | Re: Fwd: [GENERAL] 4B row limit for CLOB tables |
Previous Message | Michael Paquier | 2015-04-24 02:26:57 | Re: Supporting TAP tests with MSVC and Windows |