| From: | Stephen Frost <sfrost(at)snowman(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | preprocess_targetlist and inheiritance |
| Date: | 2015-04-21 15:15:11 |
| Message-ID: | 20150421151511.GL30322@tamriel.snowman.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom, all,
Looks like preprocess_targetlist() should have been adjusted with the
changes to ExecBuildAuxRowMark() to support foreign tables being part
of inheritance trees (cb1ca4d800621dcae67ca6c799006de99fa4f0a5) to
also include the tableoid regardless of the rowMark type, if the
relation is the parent of an inheritance tree.
This was noted by Dean Rasheed while working on RLS since it was
causing one of the new RLS-with-inheritance regression tests to fail
with: ERROR: could not find junk tableoid1 column
This does change the output a bit in the regression tests due to the
change in ordering of the columns displayed by explain.
Patch attached for your review.
Thoughts?
I'm happy to push this if no one has any issues with it, but also
won't object if you'd prefer to.
Thanks!
Stephen
| Attachment | Content-Type | Size |
|---|---|---|
| preprocess_targetlist_inheritance.patch | text/x-diff | 9.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sawada Masahiko | 2015-04-21 15:15:53 | Re: Freeze avoidance of very large table. |
| Previous Message | Andrew Gierth | 2015-04-21 15:06:58 | Re: WIP Patch for GROUPING SETS phase 1 |