| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Shouldn't CREATE TABLE LIKE copy the relhasoids property? |
| Date: | 2015-04-20 21:41:16 |
| Message-ID: | 20150420214116.GT11720@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Apr 20, 2015 at 05:04:14PM -0400, Robert Haas wrote:
> On Mon, Apr 20, 2015 at 4:11 PM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> > Slightly improved patch applied.
>
> Is it?
The patch has a slightly modified 'if' statement to check a constant
before calling a function, and use elseif:
< + if (!interpretOidsOption(stmt->options, true) && cxt.hasoids)
---
> + if (cxt.hasoids && !interpretOidsOption(stmt->options, true))
47c57
< + if (interpretOidsOption(stmt->options, true) && !cxt.hasoids)
---
> + else if (!cxt.hasoids && interpretOidsOption(stmt->options, true))
I realize the change is subtle.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ Everyone has their own god. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2015-04-20 21:44:33 | Re: Turning off HOT/Cleanup sometimes |
| Previous Message | Peter Geoghegan | 2015-04-20 21:37:50 | Re: Clock sweep not caching enough B-Tree leaf pages? |