Re: [COMMITTERS] pgsql: Move pg_upgrade from contrib/ to src/bin/

Michael Paquier wrote:
> On Thu, Apr 16, 2015 at 4:15 AM, Alvaro Herrera
> <alvherre(at)2ndquadrant(dot)com> wrote:

> > Well, *I* can't write the MSVC patch, but I can't find anyone to
> > volunteer some time either :-( I think it's best to have MSVC skip the
> > step and have the Makefile-based animals run it. That would give us a
> > lot more coverage than currently, which is just two animals AFAIU.
>
> Meh. I'll just do it then. We've been slacking for some time regarding
> that, and it is not cool to have the modules untested on Windows.

No kidding.

> So let's do the following:
> - Rework the patch doing refactoring of contrib/ and src/test/modules in MSVC.
> - Include the modules in install when install target is 'all' or
> default, like we did in previous releases.
> - Add a new option in vcregress, modulecheck to kick the tests of
> those modules. vcregress will need to refactoring as well. This makes
> 3 patches visibly, one for the build part, one for the install part
> and one for vcregress.
> Sounds fine?

Sounds like a plan.

> >> We've handled the buildfarm being red for a few days before. People are
> >> usually good about applying fixes fairly quickly.
> >
> > Okay.
>
> I did it on my stuff already...

Great. It's a bit less red already ...

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services