Re: Assert there is no duplicated exit callbacks

From: David Fetter <david(at)fetter(dot)org>
To: Qingqing Zhou <zhouqq(dot)postgres(at)gmail(dot)com>
Cc: hlinnaka(at)iki(dot)fi, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Assert there is no duplicated exit callbacks
Date: 2015-04-15 18:28:56
Message-ID: 20150415182856.GA7385@fetter.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Apr 15, 2015 at 11:14:43AM -0700, Qingqing Zhou wrote:
> Hmm, the email text seems corrupted?

I think it was an encoding issue. Here's what I got when I piped it
through less.

Cheers,
David.

On 04/15/2015 07:52 PM, Qingqing Zhou wrote:
> Attached is a patch to assert there is no duplicated exit callbacks.

I don't remember that ever been a problem.

> Along the way, I downgrade the runtime "enough room" check to an
> assertion: the callbacks are registered in pretty fixed initialization
> code path, thus assertion is good enough to prevent overlook there. If
> we don't agree with this, then the duplication check shall also bump
> to runtime checks.

I don't think any of this is needed.

- Heikki
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2015-04-15 19:02:05 Re: [COMMITTERS] pgsql: Move pg_upgrade from contrib/ to src/bin/
Previous Message Qingqing Zhou 2015-04-15 18:14:43 Re: Assert there is no duplicated exit callbacks