Re: pgsql: Mark the second argument of pg_log as the translatable string in

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Fujii Masao <fujii(at)postgresql(dot)org>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Mark the second argument of pg_log as the translatable string in
Date: 2015-04-12 01:17:15
Message-ID: 20150412011715.GK4369@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Peter Eisentraut wrote:
> On 4/7/15 10:06 PM, Fujii Masao wrote:
> > Mark the second argument of pg_log as the translatable string in nls.mk.
>
> gettext (msgmerge) is unhappy about this because
>
> po/pg_rewind.pot:501: warning: internationalized messages should not
> contain the '\r' escape sequence

What pg_basebackup's progress_report() does is have the message in the
translatable part not include the \r; the \r is in a separate fprintf()
call.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2015-04-12 03:34:54 pgsql: Move pg_archivecleanup from contrib/ to src/bin/
Previous Message Peter Eisentraut 2015-04-12 01:08:55 Re: pgsql: Mark the second argument of pg_log as the translatable string in