| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: NOT NULL markings for BKI columns |
| Date: | 2015-04-09 11:33:08 |
| Message-ID: | 20150409113308.GA23636@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> Specifically, this code chunk:
>
> + if (defined $attopt)
> + {
> + if ($attopt eq 'PG_FORCE_NULL')
> + {
> + $row{'forcenull'} = 1;
> + }
> + elsif ($attopt eq 'BKI_FORCE_NOT_NULL')
> + {
> + $row{'forcenotnull'} = 1;
> + }
> + else
> + {
> + die "unknown column option $attopt on column
> $attname"
> + }
> + }
>
> We should have BKI_FORCE_NULL instead of PG_FORCE_NULL in the comparison.
Ick. Thanks. Fixed.
Just out of interest and if you can answer: What are you using it for? I
guess it's AS?
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2015-04-09 12:20:45 | Re: "rejected" vs "returned with feedback" in new CF app |
| Previous Message | Magnus Hagander | 2015-04-09 11:31:55 | Re: SSL information view |