Re: [COMMITTERS] pgsql: btree_gin: properly call DirectFunctionCall1()

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org>
Subject: Re: [COMMITTERS] pgsql: btree_gin: properly call DirectFunctionCall1()
Date: 2015-03-26 00:51:23
Message-ID: 20150326005123.GB31152@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Tue, Mar 24, 2015 at 10:35:10PM -0400, Bruce Momjian wrote:
> On Tue, Mar 24, 2015 at 10:02:03PM -0400, Tom Lane wrote:
> > Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > > btree_gin: properly call DirectFunctionCall1()
> > > Previously we called DirectFunctionCall3() with dummy arguments.
> >
> > This patch is entirely wrong and has broken the buildfarm.
> > Please revert.
>
> OK, done.

OK, I figured out that I was only supposed to change inet_in, not the
other calls to DirectFunctionCall3 (varbit_in and bit_in). Patch
attached.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +

Attachment Content-Type Size
btree_gin.diff text/x-diff 722 bytes

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tatsuo Ishii 2015-03-26 01:42:41 pgsql: Make SyncRepWakeQueue to a static function
Previous Message Tom Lane 2015-03-25 23:11:06 Re: [COMMITTERS] pgsql: Add macros wrapping all usage of gcc's __attribute__.

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2015-03-26 00:55:45 Re: Error with index on unlogged table
Previous Message Michael Paquier 2015-03-26 00:43:58 Re: Error with index on unlogged table