| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | Abhijit Menon-Sen <ams(at)2ndQuadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: What exactly is our CRC algorithm? |
| Date: | 2015-03-25 17:20:22 |
| Message-ID: | 20150325172022.GD451@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2015-03-25 19:18:51 +0200, Heikki Linnakangas wrote:
> I was just about to commit the attached, which is the same as the previous
> patch with just cosmetic comment changes, but then I realized that this
> probably doesn't compile with Visual Studio 2005 or older. The code does
> "#ifdef _MSC_VER", and then uses the _mm_crc32_u64 intrinsic, but that
> intrinsic was added in Visual Studio 2008. I think we'll need a version
> check there.
Good catch.
> Or better yet, a direct configure test to check if the
> intrinsic exists - that way we get to also use it on Intel compilers, which
> I believe also has the same intrinsics.
Maybe I'm missing something, but configure isn't run for msvc?
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2015-03-25 17:24:26 | Re: What exactly is our CRC algorithm? |
| Previous Message | Heikki Linnakangas | 2015-03-25 17:18:51 | Re: What exactly is our CRC algorithm? |