Re: WIP Patch for GROUPING SETS phase 1

From: Svenne Krap <svenne(at)krap(dot)dk>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Re: WIP Patch for GROUPING SETS phase 1
Date: 2015-03-18 16:18:02
Message-ID: 20150318161802.4007.56450.pgcf@coridan.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

The following review has been posted through the commitfest application:
make installcheck-world: tested, failed
Implements feature: tested, passed
Spec compliant: not tested
Documentation: tested, passed

This is a midway review, a later will complete it.

The patch applies against 8d1f239003d0245dda636dfa6cf0add13bee69d6 and builds correctly. Make installcheck-world fails, but it seems to be somewhere totally unrelated (TCL pl)...

The documentation is very well-written and the patch implements the documented syntax.

I still need to check against the standard and I will run it against a non-trivival production load... hopefully I will finish up my review shortly after the weekend...

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2015-03-18 16:19:04 Re: INSERT ... ON CONFLICT IGNORE (and UPDATE) 3.0
Previous Message Tom Lane 2015-03-18 16:11:22 Re: pg9.4 relpages of child tables