Re: pgsql: Add GUC to enable compression of full page images stored in WAL.

Hi,

On 2015-03-11 06:54:16 +0000, Fujii Masao wrote:
> Add GUC to enable compression of full page images stored in WAL.

This triggers a couple warnings here (gcc 4.9 and 5):

/home/andres/src/postgresql/src/backend/access/transam/xloginsert.c: In function ‘XLogInsert’:
/home/andres/src/postgresql/src/backend/access/transam/xloginsert.c:670:5: warning: ‘cbimg.hole_length’ may be used uninitialized in this function [-Wmaybe-uninitialized]
memcpy(scratch, &cbimg,
^
/home/andres/src/postgresql/src/backend/access/transam/xloginsert.c:494:33: note: ‘cbimg.hole_length’ was declared here
XLogRecordBlockCompressHeader cbimg;
^
/home/andres/src/postgresql/src/backend/access/transam/xloginsert.c:668:20: warning: ‘hole_length’ may be used uninitialized in this function [-Wmaybe-uninitialized]
if (hole_length != 0 && is_compressed)
^
/home/andres/src/postgresql/src/backend/access/transam/xloginsert.c:497:10: note: ‘hole_length’ was declared here
uint16 hole_length;

I've not checked whether they're spurious or not.

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services