Re: Bug in pg_dump

* Michael Paquier (michael(dot)paquier(at)gmail(dot)com) wrote:
> On Mon, Mar 2, 2015 at 6:27 AM, Stephen Frost <sfrost(at)snowman(dot)net> wrote:
> > Please see the latest version of this, attached. I've removed the left
> > join, re-used the 'query' buffer (instead of destroying and recreating
> > it), and added a bit of documentation, along with a note in the commit
> > message for the release notes.
>
> Thanks, those modifications look good to me.

Ok, I've pushed the pg_dump fix for all the branches it applies to.
Thanks for the help!

> > Would be great if you could review it and let me know. As mentioned in
> > my other email, I'm happy to include the TAP test in master once we've
> > worked out the correct way to handle installing the extension for
> > testing in the Makefile system.
>
> Sure. As that's unrelated to this thread, perhaps we could discuss
> this point on another thread with refreshed patches? I'd like to hear
> some input from Peter on the matter as well.

That's fine with me- feel free to start a new thread with new patches.

Thanks again!

Stephen