From: | David Fetter <david(at)fetter(dot)org> |
---|---|
To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
Cc: | Gilles Darold <gilles(dot)darold(at)dalibo(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Bug in pg_dump |
Date: | 2015-02-27 17:41:26 |
Message-ID: | 20150227174126.GA4621@fetter.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Feb 26, 2015 at 08:41:46PM +0900, Michael Paquier wrote:
> On Wed, Feb 25, 2015 at 7:46 AM, Gilles Darold <gilles(dot)darold(at)dalibo(dot)com> wrote:
> > This is a far better patch and the test to export/import of the
> > postgis_topology extension works great for me.
> >
> > Thanks for the work.
>
> Attached is a patch that uses an even better approach by querying
> only once all the FK dependencies of tables in extensions whose data
> is registered as dumpable by getExtensionMembership(). Could you
> check that it works correctly? My test case passes but an extra
> check would be a good nice. The patch footprint is pretty low so we
> may be able to backport this patch easily.
+1 for backporting. It's a real bug, and real people get hit by it if
they're using PostGIS, one of our most popular add-ons.
Cheers,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com
Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate
From | Date | Subject | |
---|---|---|---|
Next Message | Tomas Vondra | 2015-02-27 17:48:30 | Re: Providing catalog view to pg_hba.conf file - Patch submission |
Previous Message | Pavel Stehule | 2015-02-27 17:29:13 | Re: Providing catalog view to pg_hba.conf file - Patch submission |