From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
---|---|
To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
Cc: | PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: event triggers with args? |
Date: | 2015-02-25 10:47:51 |
Message-ID: | 20150225104751.GA5268@alap3.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2015-02-25 10:43:57 +0100, Fabien COELHO wrote:
>
> While looking at event triggers, I noticed that, contrary to basic triggers,
> arguments are not allowed.
>
> However, the example in the documentation with an hour-based filtering of
> ddl commands suggest some handling of arguments would be useful so as to
> allow more generic event triggers.
>
> So I have a question: is there a particular reason why arguments were not
> provided in the first place?
Yea. The existing trigger argument mechanims is extremely odd
implementation wise - they don't have real datatypes and aren't passed
via the normal parameter passing mechanism. IIRC we discussed this back
when it was introduced and decided against introducing for now.
I think the whole trigger argument infrastructure, even for normal
triggers, should be rewritten. After that we could think of adding it
for event triggers.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Tomas Vondra | 2015-02-25 10:52:05 | Re: Fillfactor for GIN indexes |
Previous Message | Simon Riggs | 2015-02-25 10:09:54 | Re: Merge compact/non compact commits, make aborts dynamically sized |