Re: OBJECT_ATTRIBUTE is useless (or: ALTER TYPE vs ALTER TABLE for composites)

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: OBJECT_ATTRIBUTE is useless (or: ALTER TYPE vs ALTER TABLE for composites)
Date: 2015-02-24 18:09:32
Message-ID: 20150224180932.GJ5169@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut wrote:
> On 2/23/15 2:01 PM, Alvaro Herrera wrote:
> > I found that the OBJECT_ATTRIBUTE symbol is useless. I can just remove
> > it and replace it with OBJECT_COLUMN, and everything continues to work;
> > no test fails that I can find.
>
> It appears that it would change the command tag from ALTER TYPE to ALTER
> TABLE.

Ah, that it does. I guess I unconsciously believed that command tags
would be part of regression tests expected output, but clearly they are
not.

I don't think this change is all that terrible, but I've seen past
discussions about changing command type and they aren't pretty, so I
will drop this.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2015-02-24 18:37:39 Re: PostgreSQL on z/OS UNIX?
Previous Message Jim Nasby 2015-02-24 18:08:08 Re: a fast bloat measurement tool (was Re: Measuring relation free space)