Re: deparsing utility commands

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Stephen Frost <sfrost(at)snowman(dot)net>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: deparsing utility commands
Date: 2015-02-21 12:13:21
Message-ID: 20150221121321.GA10608@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2015-02-19 17:14:57 -0300, Alvaro Herrera wrote:
> The ddl_command_start event occurs just before the execution of
> a CREATE, ALTER, DROP, SECURITY LABEL, COMMENT, GRANT or REVOKE
> command. No check whether the affected object exists or doesn't
> exist is performed before the event trigger fires. As an
> exception, however, this event does not occur for DDL commands
> targeting shared objects — databases, roles, and tablespaces —
> or for commands targeting event triggers themselves.
>
> So adding more text to the same effect would be repetitive. I added a
> sixth column "Notes" to the table of supported command tags vs. events,
> with the text "Only for local objects" next to the four commands being
> added here.

I think that's sufficient for now. We might want to expand the handling
of 'global objects' topic sometime in the future, but for now I think
what you have is clear enough.

> I think it's fair to push this patch as is.

+1

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2015-02-21 12:22:22 Re: deparsing utility commands
Previous Message Andres Freund 2015-02-21 10:04:19 Re: Bootstrap DATA is a pita