Re: sloppy back-patching of column-privilege leak

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: sloppy back-patching of column-privilege leak
Date: 2015-02-09 21:20:37
Message-ID: 20150209212037.GZ3854@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Alvaro,

* Alvaro Herrera (alvherre(at)2ndquadrant(dot)com) wrote:
> FWIW using different commit messages for different branches is a
> mistake. The implicit policy we have is that there is one message,
> identical for all branches, that describe how the patch differs in each
> branch whenever necessary. Note that the git_changelog output that
> Robert pasted is not verbatim from the tool; what it actually prints is
> three separate entries, one for each different message you used, which
> is not what is supposed to occur.

Ok, thanks. That's certainly easy enough to do and I'll do so in the
future. I could have sworn I'd seen cases where further clarification
was done for branch-specific commits but perhaps something else was
different there.

> I say this policy is implicit because I don't recall it being spelled
> out anywhere, but since it's embodied in git_changelog's working
> principle it's important we stick to it.

I have to admit that I've never really used git_changelog.

Thanks!

Stephen

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Antonin Houska 2015-02-09 21:23:27 Corner case for add_path_precheck
Previous Message Stephen Frost 2015-02-09 21:17:30 Re: Odd behavior of updatable security barrier views on foreign tables