Re: [COMMITTERS] pgsql: Fix column-privilege leak in error-message paths

Tom,

* Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
> Stephen Frost <sfrost(at)snowman(dot)net> writes:
> > Fix column-privilege leak in error-message paths

[...]

> The cause of that is the logic added to BuildIndexValueDescription, which
> ignores the possibility that some of the index columns are expressions
> (which will have a zero in indkey[]).
>
> I'm not sure that it's worth trying to drill down and determine exactly
> which column(s) are referenced by an expression. I'd be content if we
> just decided that any index expression is off-limits to someone without
> full SELECT access, which could be achieved with something like

Commit pushed with this approach.

> (though a comment about it wouldn't be a bad thing either)

and a comment added explaining it.

Thanks again for pointing it out and please let me know if you see any
further issues.

Stephen