Re: pgsql: adjust ACL owners for REASSIGN and ALTER OWNER TO

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: adjust ACL owners for REASSIGN and ALTER OWNER TO
Date: 2015-01-22 18:09:16
Message-ID: 20150122180916.GH27749@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Thu, Jan 22, 2015 at 02:54:51PM -0300, Alvaro Herrera wrote:
> Bruce Momjian wrote:
> > adjust ACL owners for REASSIGN and ALTER OWNER TO
> >
> > When REASSIGN and ALTER OWNER TO are used, both the object owner and ACL
> > list should be changed from the old owner to the new owner. This patch
> > fixes types, foreign data wrappers, and foreign servers to change their
> > ACL list properly; they already changed owners properly.
>
> Isn't this a backpatchable bug fix?

Uh, I don't think so as it changes _security_ behavior that people might
be relying on. The issue is that you might be expecting to keep the
same permissions on the old owner and your script might just add the new
owner ACL, while the patch removes the old owner's ACL and adds the new
user to be consistent with other types.

My big question is whether this change is something we would mention as
backward incompatible in the 9.5 release notes.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2015-01-22 18:30:13 pgsql: docs: update libpq's PQputCopyData and PQputCopyEnd
Previous Message Alvaro Herrera 2015-01-22 17:54:51 Re: pgsql: adjust ACL owners for REASSIGN and ALTER OWNER TO