From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: [COMMITTERS] pgsql: Disable -faggressive-loop-optimizations in gcc 4.8+ for pre-9.2 |
Date: | 2015-01-20 15:30:21 |
Message-ID: | 20150120153020.GN1663@alvh.no-ip.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Tom Lane wrote:
> Disable -faggressive-loop-optimizations in gcc 4.8+ for pre-9.2 branches.
>
> With this optimization flag enabled, recent versions of gcc can generate
> incorrect code that assumes variable-length arrays (such as oidvector)
> are actually fixed-length because they're embedded in some larger struct.
> The known instance of this problem was fixed in 9.2 and up by commit
> 8137f2c32322c624e0431fac1621e8e9315202f9 and followon work, which hides
> actually-variable-length catalog fields from the compiler altogether.
> And we plan to gradually convert variable-length fields to official
> "flexible array member" notation over time, which should prevent this type
> of bug from reappearing as gcc gets smarter. We're not going to try to
> back-port those changes into older branches, though, so apply this
> band-aid instead.
Would anybody object to me pushing this commit to branches 8.2 and 8.3?
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2015-01-20 15:54:04 | pgsql: Add strxfrm_l to list of functions where Windows adds an undersc |
Previous Message | Tom Lane | 2015-01-20 04:44:55 | pgsql: In pg_regress, remove the temporary installation upon successful |
From | Date | Subject | |
---|---|---|---|
Next Message | Tomas Vondra | 2015-01-20 15:40:30 | Re: PATCH: decreasing memory needlessly consumed by array_agg |
Previous Message | Andres Freund | 2015-01-20 15:28:19 | basebackups during ALTER DATABASE ... SET TABLESPACE ... not safe? |