Re: Proposal: Log inability to lock pages during vacuum

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: Jim Nasby <Jim(dot)Nasby(at)BlueTreble(dot)com>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Proposal: Log inability to lock pages during vacuum
Date: 2015-01-08 12:19:23
Message-ID: 20150108121923.GB12509@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2015-01-04 01:53:24 +0100, Andres Freund wrote:
> > >Ah, interesting, I didn't remember we had that. I guess one possible
> > >tweak is to discount the pages we skip from pinned_pages; or we could
> > >keep a separate count of pages waited for. Jim, up for a patch?
>
> This is still wrong. I think just counting skipped pages, without
> distinct messages for waiting/not waiting, is good enough for
> now. Everything else would only be actually meaningful if we actually
> tracked the waiting time.

Pushed a commit for this, with additional improvements to autovacuum's
log output from:
LOG: automatic vacuum of table "postgres.public.frak": index scans: 0
pages: 0 removed, 1672 remain
skipped 1 pages due to buffer pins
tuples: 0 removed, 309959 remain, 309774 are dead but not yet removable
buffer usage: 4258 hits, 0 misses, 0 dirtied
avg read rate: 0.000 MB/s, avg write rate: 0.000 MB/s
system usage: CPU 0.00s/0.04u sec elapsed 0.46 sec
to:
LOG: automatic vacuum of table "postgres.public.frak": index scans: 0
pages: 0 removed, 1672 remain, 1 skipped due to pins
tuples: 0 removed, 309959 remain, 309774 are dead but not yet removable
buffer usage: 4258 hits, 0 misses, 0 dirtied
avg read rate: 0.000 MB/s, avg write rate: 0.000 MB/s
system usage: CPU 0.00s/0.04u sec elapsed 0.46 sec
as the 'skipped ...' line didn't really look in line with the rest.

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Dean Rasheed 2015-01-08 12:24:27 Re: Possible typo in create_policy.sgml
Previous Message Amit Kapila 2015-01-08 11:52:26 Re: parallel mode and parallel contexts