Re: pg_basebackup -x/X doesn't play well with archive_mode & wal_keep_segments

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_basebackup -x/X doesn't play well with archive_mode & wal_keep_segments
Date: 2015-01-03 20:47:56
Message-ID: 20150103204756.GE3064@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2015-01-03 16:03:36 +0100, Andres Freund wrote:
> On 2014-12-31 16:32:19 +0100, Andres Freund wrote:
> > On 2014-12-05 16:18:02 +0900, Fujii Masao wrote:
> > > On Fri, Dec 5, 2014 at 9:28 AM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
> > > > So I think we just need to make pg_basebackup create to .ready
> > > > files.
> > >
> > > s/.ready/.done? If yes, +1.
> >
> > That unfortunately requires changes to both backend and pg_basebackup to
> > support fetch and stream modes respectively.
> >
> > I've attached a preliminary patch for this. I'd appreciate feedback. I
> > plan to commit it in a couple of days, after some more
> > testing/rereading.
>
> Attached are two updated patches that I am starting to backport
> now. I've fixed a couple minor oversights. And tested the patches.

Pushed this after some major pain with backporting. pg_basebackup really
changed heavily since it's introduction. And desparately needs some
restructuring.

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Fetter 2015-01-03 21:33:23 Re: Small doc patch about pg_service.conf
Previous Message Peter Geoghegan 2015-01-03 20:42:24 Re: Problems with approach #2 to value locking (INSERT ... ON CONFLICT UPDATE/IGNORE patch)