Re: pgsql: Don't run rowsecurity in parallel with other regression tests.

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Don't run rowsecurity in parallel with other regression tests.
Date: 2015-01-02 13:47:29
Message-ID: 20150102134729.GY3062@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

* Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
> Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> > Tom Lane wrote:
> >> Don't run rowsecurity in parallel with other regression tests.
> >>
> >> The short-lived event trigger in the rowsecurity test causes irreproducible
> >> failures when the concurrent tests do something that the event trigger
> >> can't cope with. Per buildfarm.
>
> > Ah, so this explains the failures.
>
> > I wonder if it'd be better to remove the event trigger bits from that
> > test, and put them (if we really need them) in the event_trigger test.

That makes sense to me.

> I'd be fine with reverting this commit if Stephen wants to refactor the
> rowsecurity/event_trigger tests that way. Dunno if it makes sense to
> do that though.

I'll move the event trigger in the rowsecurity tests over to the
event_trigger test and then move the rowsecurity tests back into the
parallel group.

Please let me know if there's any concerns with this approach.

Thanks!

Stephen

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2015-01-02 14:42:55 Re: pgsql: Don't run rowsecurity in parallel with other regression tests.
Previous Message Tom Lane 2014-12-31 22:24:28 Re: pgsql: Don't run rowsecurity in parallel with other regression tests.