Re: [COMMITTERS] pgsql/src/backend/postmaster postmaster.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql/src/backend/postmaster postmaster.c
Date: 2001-11-11 16:57:07
Message-ID: 20144.1005497827@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> How about this:

> elog(xxx, "whatever process (pid %d) terminated abnormally (%s)", formatExitStatus(exit_status));

> where formatExitStatus() returns either of

> "exit status 77"
> "signal 11"

But exit status 0 is not abnormal. I guess in the CleanupProc case
you could leave out the word "abnormally" and just say terminated (%s).

> I see you already made some changes. Sorry that it took me a while to
> respond, but I can make these changes if we can agree.

I took your lack of comment as assent ... if you want to change it as
above, I won't object, but I think what's there now is workable as long
as the translator understands that the two sets of messages go together.

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message tgl 2001-11-11 19:18:55 pgsql/src/backend/optimizer/path joinpath.c
Previous Message Peter Eisentraut 2001-11-11 15:40:54 Re: [COMMITTERS] pgsql/src/backend/postmaster postmaster.c

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephan Szabo 2001-11-11 18:54:05 Triggered Data Change check
Previous Message Tom Lane 2001-11-11 16:49:47 Re: Bug #513: union all changes char(3) column definition