Re: Re: [COMMITTERS] pgsql: pg_event_trigger_dropped_objects: Add name/args output columns

Tom Lane wrote:

> But is there any reason to think the failure on dunlin has anything to do
> with default ACLs? I think you'd better work on understanding why there
> is a platform dependency here, before you consider either removing the
> regression test case or adding support for object types that it shouldn't
> be hitting.

Thanks for the commit. Now dunlin is green, but treepie displayed the
failure, so we know it's not a platform dependency but probably a timing
dependency. The failure from treepie is

*** 1323,1328 ****
--- 1323,1329 ----

DROP SCHEMA testns CASCADE;
NOTICE: drop cascades to table testns.acltest1
+ ERROR: requested object address for unsupported object class 28: text result "for role regressuser1 in schema testns on types"
SELECT d.* -- check that entries went away
FROM pg_default_acl d LEFT JOIN pg_namespace n ON defaclnamespace = n.oid
WHERE nspname IS NULL AND defaclnamespace != 0;

where 28 is OCLASS_DEFACL, which is consistent with the text result. I
have no idea why this is being invoked but it seems clear to me now that
we need to support this case. I will work on that on Friday, and also
check whether we need to add the AMPROC/AMOP cases and USER_MAPPING.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services