| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Alex Shulgin <ash(at)commandprompt(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Small TRUNCATE glitch |
| Date: | 2014-12-10 09:58:21 |
| Message-ID: | 20141210095821.GC13011@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Dec 10, 2014 at 10:32:42AM +0200, Heikki Linnakangas wrote:
> >I don't think we need to have 2PC files survive a pg_upgrade. It seems
> >perfectly okay to remove them from the new cluster at some appropriate
> >time, *if* they are copied from the old cluster at all (I don't think
> >they should be.)
>
> I think pg_upgrade should check if there are any prepared
> transactions pending, and refuse to upgrade if there are. It could
> be made to work, but it's really not worth the trouble. If there are
> any pending prepared transactions in the system when you run
> pg_upgrade, it's more likely to be a mistake or oversight in the
> first place, than on purpose.
pg_upgrade already checks for prepared transactions and errors out if
they exist; see check_for_prepared_transactions().
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ Everyone has their own god. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2014-12-10 10:04:39 | Re: Removing INNER JOINs |
| Previous Message | Bruce Momjian | 2014-12-10 09:53:15 | Re: GSSAPI, SSPI - include_realm default |