| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Alex Shulgin <ash(at)commandprompt(dot)com> |
| Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Small TRUNCATE glitch |
| Date: | 2014-12-10 01:04:05 |
| Message-ID: | 20141210010405.GU1768@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alex Shulgin wrote:
> The 2PC part requires extending bool flag to fit the trunc flag, is this
> approach sane? Given that 2PC transaction should survive server
> restart, it's reasonable to expect it to also survive the upgrade, so I
> see no clean way of adding another bool field to the
> TwoPhasePgStatRecord struct (unless some would like to add checks on
> record length, etc.).
I don't think we need to have 2PC files survive a pg_upgrade. It seems
perfectly okay to remove them from the new cluster at some appropriate
time, *if* they are copied from the old cluster at all (I don't think
they should be.)
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Josh Berkus | 2014-12-10 01:46:34 | Re: Yet another abort-early plan disaster on 9.3 |
| Previous Message | Alvaro Herrera | 2014-12-10 01:00:55 | Re: logical column ordering |