Re: superuser() shortcuts

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: Andres Freund <andres(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Adam Brightwell <adam(dot)brightwell(at)crunchydatasolutions(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: superuser() shortcuts
Date: 2014-12-04 22:25:20
Message-ID: 20141204222520.GB1768@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Stephen Frost wrote:
> * Andres Freund (andres(at)2ndquadrant(dot)com) wrote:
> > On 2014-12-04 15:59:17 -0500, Stephen Frost wrote:

> > > > I just don't understand why you want to pointlessly tinker with this.
> > >
> > > Because I don't feel it's pointless to improve the consistency of the
> > > error messaging and I don't like that it's inconsistent today.
> >
> > Then please do so outside of patches/threads that do something pretty
> > much unrelated.
>
> Alright, I bothered to go back and find the relevant message- it's this
> one: 20141022231834(dot)GA1587(at)alvin(dot)alvh(dot)no-ip(dot)org where Alvaro pointed out
> that the messaging is inconsistent and asked that this patch should
> include the correct wording (whatever we decide it to be) and further
> commentary in 20141023232302(dot)GH1791(at)alvin(dot)alvh(dot)no-ip(dot)org matches that..
> I didn't bring this up and I'm getting a bit put-out by the constant
> implications that it's just all me and my crazy ideas for consistency.
> Perhaps Alvaro doesn't care to argue the position further, which is
> fine, but at least acknowledge that there are others who agree that
> we're currently inconsistent (Alvaro and, I believe, Peter).

Several dozens messages ago in this thread I would have dropped this
item, TBH. *Maybe* I would consider changing the specific messages
around the specific code that's being tinkered with, but probably not
other ones.

I haven't looked at this patch recently, but if it's changing 1% of the
error messages in the backend, I doubt it's a good idea.

More in general, if I see strong, well-rationalized opposition to some
non-essential idea of mine, I tend to drop it because I don't see the
value in arguing endlessly. Life's already way too short.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2014-12-04 22:30:44 Re: superuser() shortcuts
Previous Message Stephen Frost 2014-12-04 22:06:02 Re: superuser() shortcuts