| From: | Stephen Frost <sfrost(at)snowman(dot)net> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Review of GetUserId() Usage |
| Date: | 2014-12-02 20:23:16 |
| Message-ID: | 20141202202315.GW3342@tamriel.snowman.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
* Stephen Frost (sfrost(at)snowman(dot)net) wrote:
> > 3. It messes around with pg_signal_backend(). There are currently no
> > cases in which pg_signal_backend() throws an error, which is good,
> > because it lets you write queries against pg_stat_activity() that
> > don't fail halfway through, even if you are missing permissions on
> > some things. This patch introduces such a case, which is bad.
>
> Good point, I'll move that check up into the other functions, which will
> allow for a more descriptive error as well.
Err, I'm missing something here, as pg_signal_backend() is a misc.c
static internal function? How would you be calling it from a query
against pg_stat_activity()?
I'm fine making the change anyway, just curious..
Thanks,
Stephen
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2014-12-02 20:30:29 | Re: Review of GetUserId() Usage |
| Previous Message | Jeff Janes | 2014-12-02 20:22:42 | Re: How about a option to disable autovacuum cancellation on lock conflict? |