| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: no test programs in contrib |
| Date: | 2014-11-27 22:26:49 |
| Message-ID: | 20141127222649.GV1639@alvin.alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> I'm not too happy with that approach, because packagers are going to
> tend to think they should package any files installed by install-world.
> The entire point of this change, IMO, is that the test modules should
> *not* get installed, certainly not by normal install targets. Being
> consistent with the existing contrib packaging is exactly not what we
> want.
>
> Maybe we should only allow check-world to run these tests, and not
> installcheck-world? That's kind of annoying, but what you are
> doing now seems to defeat the purpose altogether.
Hadn't thought of the packaging angle of this. I don't think packagers
really are as dumb as you suggest, but anyway implementing this idea
turned out to be simpler than I expected; here's a preliminary patch.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| test_modules_3a.patch | text/x-diff | 1.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2014-11-27 23:24:40 | Re: [pgsql-packagers] Palle Girgensohn's ICU patch |
| Previous Message | Tom Lane | 2014-11-27 20:51:51 | Re: no test programs in contrib |