Re: BUG #11882: make HAVE_WORKING_LINK an option

Hi,

On 2014-11-05 14:44:48 +0000, gauchard(at)laas(dot)fr wrote:
> This define "HAVE_WORKING_LINK" should not be always enabled. On systems
> that support (and surely use) hard links FS, postgresql might be used on a
> subFS not supporting it.
> In the sources, the comment is (from git's
> src/backend/access/transam/xlog.c):

Those FS's really shouldn't be used for a database though. Are you
thinking of something concrete?

> 3373 * Prefer link() to rename() here just to be really sure that we
> don't
> 3374 * overwrite an existing logfile. However, there shouldn't be one,
> so
> 3375 * rename() is an acceptable substitute except for the truly
> paranoid.

> My thinking is that you may add a '--paranoid' option to use hardlink
> instead of rename, or, at least, an option (--relax ?) to disable this
> behaviour and use a regular rename() instead.

I don't think this is really warranted by anything.

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services