Re: pgsql: doc: Wording and formatting improvements in new logical decoding

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: doc: Wording and formatting improvements in new logical decoding
Date: 2014-10-31 06:34:52
Message-ID: 20141031063452.GC13584@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Hi,

On 2014-10-31 02:57:21 +0000, Peter Eisentraut wrote:
> doc: Wording and formatting improvements in new logical decoding docs

Thanks for looking.

One thing I noticed is that:
-# pg_recvlogical -d postgres --slot test --create-slot
-# pg_recvlogical -d postgres --slot test --start -f -
-CTRL-Z
-# psql -d postgres -c "INSERT INTO data(data) VALUES('4');"
-# fg
+$ pg_recvlogical -d postgres --slot test --create-slot
+$ pg_recvlogical -d postgres --slot test --start -f -
+<keycombo action="simul"><keycap>Control</><keycap>D</></>
+$ psql -d postgres -c "INSERT INTO data(data) VALUES('4');"
+$ fg

looks wrong to me. Note the s/Z/D/. Or was that intentional?

Also you sometimes replaced walsender interface by
"streaming-replication interface" and sometimes by 'streaming
replication interface'. Im generally not sure that replacement is an
improvement, but it should be consistent if done.

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2014-10-31 12:14:14 pgsql: doc: Fix typos
Previous Message Peter Eisentraut 2014-10-31 02:57:21 pgsql: doc: Improve CREATE VIEW / WITH documentation