Re: Hide 'Execution time' in EXPLAIN (COSTS OFF)

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: David Rowley <dgrowleyml(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, ronan(at)dunklau(dot)fr, Christoph Berg <cb(at)df7cb(dot)de>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Markus Wanner <markus(at)bluegap(dot)ch>
Subject: Re: Hide 'Execution time' in EXPLAIN (COSTS OFF)
Date: 2014-10-19 16:32:16
Message-ID: 20141019163216.GJ22660@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2014-10-19 12:26:24 -0400, Tom Lane wrote:
> David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> > On Sat, Oct 18, 2014 at 1:39 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >> Not sure how we get there without writing our own diff engine though :-(.
>
> (Note that after a bit of looking around, it seems like it might not be
> that hard to do something like this in Perl. Perl is already
> nearly-required for building from source, could we require it for running
> the regression tests? Though we'd also need you to install
> Algorithm::Diff or suchlike, which I think isn't in a basic Perl install.)

I personally don't mind that. but if we think it's a problem, we could
quite easily embed a copy of Algorithm::Diff - easy enough with perl.

If we feel the need, we could enable the feature optionally using
resultmap. That way regression tests wouldn't get detected optionally.

I still think that reducing the need for having to do this is a good
idea, having to manually edit regression output to add regexes will be a
PITA.

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2014-10-19 16:38:52 Re: Hide 'Execution time' in EXPLAIN (COSTS OFF)
Previous Message Tom Lane 2014-10-19 16:27:34 Re: Superuser connect during smart shutdown