Re: json function volatility

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Merlin Moncure <mmoncure(at)gmail(dot)com>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: json function volatility
Date: 2014-10-17 20:59:49
Message-ID: 20141017205948.GD7246@eldon.alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Merlin Moncure wrote:
> On Fri, Oct 17, 2014 at 3:03 PM, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> > Following up something Pavel wrote, I notice that json_agg() and
> > json_object_agg() are both marked as immutable, even though they invoke IO
> > functions, while json_object is marked stable, even though it does not, and
> > can probably be marked as immutable. Mea maxima culpa.
> >
> > I'm not sure what we should do about these things now. Is it a tragedy if we
> > let these escape into the 9.4 release that way?
>
> Is it too late to change them?

One thing to consider is the catversion bump, which we don't want this
late in the cycle. Still, you could change the catalogs but not the
version, and advise those with the older definitions to tweak the
catalogs by hand if they need it. I think we did this once.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jim Nasby 2014-10-17 21:27:54 Re: Materialized views don't show up in information_schema
Previous Message Peter Geoghegan 2014-10-17 20:52:40 Re: json function volatility