Re: Shapes on the regression test for polygon

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Emre Hasegeli <emre(at)hasegeli(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Shapes on the regression test for polygon
Date: 2014-10-14 15:00:47
Message-ID: 20141014150047.GA12170@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Oct 14, 2014 at 05:40:06PM +0300, Emre Hasegeli wrote:
> > I extracted Emre's diagram adjustments from the patch and applied it,
> > and no tabs now. Emre, I assume your regression changes did not affect
> > the diagram contents.
>
> Thank you for looking at it. I wanted to make the tests consistent
> with the diagrams. Now they look better but they still don't make
> sense with the tests. I looked at it some more, and come to the
> conclusion that removing them is better than changing the tests.

OK, unless I hear more feedback I will remove the diagrams.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Eric B. Ridge 2014-10-14 15:03:34 Re: pg_get_indexdef() doesn't quote string reloptions
Previous Message Amit Kapila 2014-10-14 15:00:45 Re: WIP: dynahash replacement for buffer table