| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Sean Chittenden <sean(at)chittenden(dot)org>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] PostgreSQL 9.4 mmap(2) performance regression on FreeBSD... |
| Date: | 2014-10-13 15:35:18 |
| Message-ID: | 20141013153518.GY21267@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Oct 13, 2014 at 05:21:32PM +0200, Andres Freund wrote:
> > If we have it, we should improve it, or remove it. We might want to use
> > this code for something else in the future, so it should be improved
> > where feasible.
>
> Meh. We don't put in effort into code that doesn't matter just because
> it might get used elsewhere some day. By that argument we'd need to
> performance optimize a lot of code. And actually, using that code
> somewhere else is more of a counter indication than a pro
> argument. MAP_NOSYNC isn't a general purpose flag.
The key is that this is platform-specific behavior, so if we should use
a flag to use it right, we should. You are right that optimizing
rarely used code with generic calls isn't a good use of time.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ Everyone has their own god. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Christoph Berg | 2014-10-13 15:41:17 | Re: Hide 'Execution time' in EXPLAIN (COSTS OFF) |
| Previous Message | Andres Freund | 2014-10-13 15:26:34 | Re: [9.4 bug] The database server hangs with write-heavy workload on Windows |