Re: split builtins.h to quote.h

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Noah Misch <noah(at)leadboat(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: split builtins.h to quote.h
Date: 2014-10-11 22:09:57
Message-ID: 20141011220957.GV28859@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

* Noah Misch (noah(at)leadboat(dot)com) wrote:
> On Sat, Oct 11, 2014 at 11:43:46PM +0200, Andres Freund wrote:
> > I personally wouldn't object plaing a #include for the splitof file into
> > builtin.h to address backward compat concerns. Would imo still be an
> > improvement.
>
> Agreed. If the patch preserved compatibility by having builtins.h include
> quote.h, I would not object.

That seems reasonable to me also- though I'd caveat it as "for now" and
make sure to make a note of the reason it's included in the comments...

Thanks,

Stephen

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2014-10-11 22:40:02 Re: Is analyze_new_cluster.sh still useful?
Previous Message Noah Misch 2014-10-11 22:05:28 Re: split builtins.h to quote.h